Support for .NET 8 #2996
Merged
Support for .NET 8 #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Lock <[email protected]>
Kielek
commented
Oct 10, 2023
test/IntegrationTests/BuildTests.DistributionStructure_alpine-linux.verified.txt
Show resolved
Hide resolved
pjanotti
reviewed
Oct 10, 2023
pjanotti
reviewed
Oct 10, 2023
pjanotti
reviewed
Oct 10, 2023
pjanotti
reviewed
Oct 10, 2023
pjanotti
reviewed
Oct 10, 2023
pjanotti
reviewed
Oct 10, 2023
This was referenced Oct 30, 2023
|
Reviewed the PR, it looks good to me. Once .NET 8.0 is GA, we could update the reference and merge the PR. |
|
.NET 8.0 has been released today - https://devblogs.microsoft.com/dotnet/november-2023-updates/ |
|
@rajkumar-rangaraj, internally we have discussed Dynamic PGO impact on our bytecode instrumentation: https://devblogs.microsoft.com/dotnet/performance-improvements-in-net-8/#tiering-and-dynamic-pgo I do not think that this change breaks anything, but is there any chance that you can double check and confirm it? |
Kielek
commented
Nov 15, 2023
|
@rajkumar-rangaraj, ready for final review. Workarounds for .NET8-rc removed. EDIT: Before merge we need to adjust required builds as it was changed in this PR. |
pjanotti
approved these changes
Nov 16, 2023
rajkumar-rangaraj
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Towards: #2946
What
Support for .NET 8
Tests
Checklist
CHANGELOG.mdis updated.Notes
https://github.com/dotnet/runtime/pull/78544/files#diff-06068c51107f17306c32fecbb6c79ec0cd5f15c9c0efe8d5a42b093be05e72e7
Native code compatibility by .NET versions:
x64:
- glibc 2.17 (from CentOS 7)
- Alpine (x64 and Arm64): musl 1.2.2 (from Alpine 3.13)
- x64: glibc 2.17 (from CentOS 7)
- Alpine (x64 and Arm64): musl 1.2.2 (from Alpine 3.15)
TODOs
Replace all references to .NET8RC by stable version when possible.Consider to update OTel to 1.7.0, but it will brings upgraded references. It can be done probably in separate PR. - separate PR, probably after release based on 1.6.0.
Handle dependabot PR related to the .NET8 package updates - can be done when this is merged.